actions/http-client
1
0
Fork 0
mirror of https://github.com/actions/http-client.git synced 2025-02-24 16:22:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

it's pretty now and bump version

Browse Source
This commit is contained in:
Bryan MacFarlane 2020-04-23 16:33:34 -04:00
parent fbd137758a
commit 943067fe4c
3 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
__tests__/basics.test.ts
View File

@ -181,47 +181,47 @@ describe('basics', () => {
it('does not pass auth with diff hostname redirects', async done => {
let headers = {
"accept": "application/json",
"authorization": "shhh"
accept: 'application/json',
authorization: 'shhh'
}
let res: httpm.HttpClientResponse = await _http.get(
'https://httpbin.org/redirect-to?url=' +
encodeURIComponent('https://www.httpbin.org/get'),
headers
headers
)
expect(res.message.statusCode).toBe(200)
let body: string = await res.readBody()
let obj: any = JSON.parse(body)
// httpbin "fixes" the casing
expect(obj.headers["Authorization"]).toBeUndefined()
expect(obj.headers["authorization"]).toBeUndefined()
expect(obj.headers['Authorization']).toBeUndefined()
expect(obj.headers['authorization']).toBeUndefined()
expect(obj.url).toBe('https://www.httpbin.org/get')
done()
})
it('does not pass Auth with diff hostname redirects', async done => {
let headers = {
"Accept": "application/json",
"Authorization": "shhh"
Accept: 'application/json',
Authorization: 'shhh'
}
let res: httpm.HttpClientResponse = await _http.get(
'https://httpbin.org/redirect-to?url=' +
encodeURIComponent('https://www.httpbin.org/get'),
headers
headers
)
expect(res.message.statusCode).toBe(200)
let body: string = await res.readBody()
let obj: any = JSON.parse(body)
// httpbin "fixes" the casing
expect(obj.headers["Authorization"]).toBeUndefined()
expect(obj.headers["authorization"]).toBeUndefined()
expect(obj.headers['Authorization']).toBeUndefined()
expect(obj.headers['authorization']).toBeUndefined()
expect(obj.url).toBe('https://www.httpbin.org/get')
done()
})
})
it('does basic head request', async done => {
let res: httpm.HttpClientResponse = await _http.head(

6
index.ts
View File

@ -388,10 +388,10 @@ export class HttpClient {
// strip authorization header if redirected to a different hostname
if (parsedRedirectUrl.hostname !== parsedUrl.hostname) {
for(let header in headers){
for (let header in headers) {
// header names are case insensitive
if (header.toLowerCase() === "authorization") {
delete headers[header]
if (header.toLowerCase() === 'authorization') {
delete headers[header]
}
}
}

2
package.json
View File

@ -1,6 +1,6 @@
{
"name": "@actions/http-client",
"version": "1.0.7",
"version": "1.0.8",
"description": "Actions Http Client",
"main": "index.js",
"scripts": {